Pacing: Pacing of egress QUIC packets #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lohith-bellad
force-pushed
the
packet_pacing
branch
4 times, most recently
from
d53b9e5
to
91894fd
Compare
junhochoi
reviewed
Dec 7, 2020
junhochoi
reviewed
Dec 7, 2020
|
Please add some test for pacing rate calculation. |
lohith-bellad
force-pushed
the
packet_pacing
branch
from
91894fd
to
f5381fe
Compare
|
Added some tests for pacing. |
lohith-bellad
force-pushed
the
packet_pacing
branch
2 times, most recently
from
58bd066
to
69ae476
Compare
junhochoi
reviewed
Dec 9, 2020
LPardue
requested changes
Dec 9, 2020
LPardue
reviewed
Dec 9, 2020
lohith-bellad
force-pushed
the
packet_pacing
branch
2 times, most recently
from
414bb66
to
da883fc
Compare
ghedo
reviewed
Dec 10, 2020
ghedo
requested changes
Dec 10, 2020
ghedo
reviewed
Dec 10, 2020
ghedo
reviewed
Dec 10, 2020
ghedo
reviewed
Dec 10, 2020
ghedo
reviewed
Dec 10, 2020
lohith-bellad
force-pushed
the
packet_pacing
branch
5 times, most recently
from
07683ee
to
08113e5
Compare
Closed
|
I've been using this branch since March and it's been working excellently for me. The only comment I have would be that paced congestion controllers like BBR may have "send quantum" as an output control signal and future work may want to allow congestion controllers to set a quantum value as well, which would cap the size of generated QUIC datagrams at that size. |
junhochoi
reviewed
May 17, 2021
ghedo
force-pushed
the
packet_pacing
branch
4 times, most recently
from
489711c
to
00513a8
Compare
junhochoi
reviewed
May 18, 2021
lohith-bellad
force-pushed
the
packet_pacing
branch
from
00513a8
to
2211080
Compare
junhochoi
previously approved these changes
May 19, 2021
ghedo
force-pushed
the
path-awareness
branch
2 times, most recently
from
b426d0c
to
c57dee4
Compare
ghedo
force-pushed
the
packet_pacing
branch
2 times, most recently
from
dcba81e
to
fe2e217
Compare
ghedo
previously approved these changes
May 24, 2021
|
FTR, I renamed the |
Closed
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently pacing is enabled for Cubic and Reno, since BBR is under development.